[Lldb-commits] [lldb] r322322 - [testsuite] Remove a broken test which tried to find App in bundles.
Davide Italiano via lldb-commits
lldb-commits at lists.llvm.org
Thu Jan 11 14:38:57 PST 2018
Author: davide
Date: Thu Jan 11 14:38:57 2018
New Revision: 322322
URL: http://llvm.org/viewvc/llvm-project?rev=322322&view=rev
Log:
[testsuite] Remove a broken test which tried to find App in bundles.
That never really worked, and the change associated isn't yet
committed, so, let's try to make the bots green for now.
Removed:
lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/Makefile
lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestApp.app/Contents/Info.plist
lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestApp.app/Contents/PkgInfo
lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestFindAppInBundle.py
lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/main.c
Removed: lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/Makefile
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/Makefile?rev=322321&view=auto
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/Makefile (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/Makefile (removed)
@@ -1,16 +0,0 @@
-CC ?= clang
-
-ifeq "$(ARCH)" ""
- ARCH = x86_64
-endif
-
-CFLAGS ?= -g -O0 -arch $(ARCH)
-
-all: clean TestApp
-
-TestApp:
- $(CC) $(CFLAGS) -o TestApp main.c
- mv TestApp TestApp.app/Contents/MacOs/TestApp
- mv TestApp.dSYM TestApp.app.dSYM
-clean:
- rm -rf TestApp.app/Contents/MacOS/TestApp TestApp.app.dSYM
Removed: lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestApp.app/Contents/Info.plist
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestApp.app/Contents/Info.plist?rev=322321&view=auto
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestApp.app/Contents/Info.plist (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestApp.app/Contents/Info.plist (removed)
@@ -1,30 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-<plist version="1.0">
-<dict>
- <key>CFBundleDevelopmentRegion</key>
- <string>en</string>
- <key>CFBundleExecutable</key>
- <string>TestApp</string>
- <key>CFBundleIdentifier</key>
- <string>com.lldb.TestApp</string>
- <key>CFBundleInfoDictionaryVersion</key>
- <string>6.0</string>
- <key>CFBundleName</key>
- <string>TestApp</string>
- <key>CFBundlePackageType</key>
- <string>APPL</string>
- <key>CFBundleShortVersionString</key>
- <string>1.0</string>
- <key>CFBundleSupportedPlatforms</key>
- <array>
- <string>MacOSX</string>
- </array>
- <key>CFBundleVersion</key>
- <string>1</string>
- <key>LSMinimumSystemVersion</key>
- <string>10.8</string>
- <key>NSHumanReadableCopyright</key>
- <string>Copyright © 2018 Jim Ingham. All rights reserved.</string>
-</dict>
-</plist>
Removed: lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestApp.app/Contents/PkgInfo
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestApp.app/Contents/PkgInfo?rev=322321&view=auto
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestApp.app/Contents/PkgInfo (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestApp.app/Contents/PkgInfo (removed)
@@ -1 +0,0 @@
-APPL????
\ No newline at end of file
Removed: lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestFindAppInBundle.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestFindAppInBundle.py?rev=322321&view=auto
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestFindAppInBundle.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestFindAppInBundle.py (removed)
@@ -1,64 +0,0 @@
-"""
-Make sure we can find the binary inside an app bundle.
-"""
-
-from __future__ import print_function
-
-
-import os
-import time
-import re
-import lldb
-from lldbsuite.test.decorators import *
-import lldbsuite.test.lldbutil as lldbutil
-import lldbsuite.test.lldbplatformutil as lldbplatformutil
-from lldbsuite.test.lldbtest import *
-
- at decorators.skipUnlessDarwin
-class FindAppInMacOSAppBundle(TestBase):
-
- mydir = TestBase.compute_mydir(__file__)
-
- NO_DEBUG_INFO_TESTCASE = True
-
- def test_find_app_in_bundle(self):
- """There can be many tests in a test case - describe this test here."""
- self.build()
- self.main_source_file = lldb.SBFileSpec("main.c")
- self.find_app_in_bundle_test()
-
- def setUp(self):
- # Call super's setUp().
- TestBase.setUp(self)
-
- def find_app_in_bundle_test(self):
- """This reads in the .app, makes sure we get the right binary and can run it."""
-
- # This function starts a process, "a.out" by default, sets a source
- # breakpoint, runs to it, and returns the thread, process & target.
- # It optionally takes an SBLaunchOption argument if you want to pass
- # arguments or environment variables.
- exe = os.path.join(os.getcwd(), "TestApp.app")
- target = self.dbg.CreateTarget(exe)
- self.assertTrue(target, "Target: TestApp.app is not valid.")
- exe_module_spec = target.GetExecutable()
- self.assertTrue(exe_module_spec.GetFilename(), "TestApp")
-
- bkpt = target.BreakpointCreateBySourceRegex("Set a breakpoint here", self.main_source_file)
- self.assertTrue(bkpt.GetNumLocations() == 1, "Couldn't set a breakpoint in the main app")
-
- if lldbplatformutil.getPlatform() == "macosx":
- launch_info = lldb.SBLaunchInfo(None)
- launch_info.SetWorkingDirectory(self.get_process_working_directory())
-
- error = lldb.SBError()
- process = target.Launch(launch_info, error)
-
- self.assertTrue(process, "Could not create a valid process for TestApp: %s"%(error.GetCString()))
-
- # Frame #0 should be at our breakpoint.
- threads = lldbutil.get_threads_stopped_at_breakpoint(process, bkpt)
-
- self.assertTrue(len(threads) == 1, "Expected 1 thread to stop at breakpoint, %d did."%(len(threads)))
-
-
Removed: lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/main.c
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/main.c?rev=322321&view=auto
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/main.c (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/main.c (removed)
@@ -1,8 +0,0 @@
-#include <stdio.h>
-
-int
-main()
-{
- printf("Set a breakpoint here.\n");
- return 0;
-}
More information about the lldb-commits
mailing list