[Lldb-commits] [PATCH] D41902: Remove Platform references from the Host module

[Jim Ingham via lldb-commits]

The only hard part of writing any kind of test for this is actually getting a legitimate .app into the testsuite.  Doesn't seem fair to ask Pavel to do that, since he doesn't work on macOS...

Jim


> On Jan 10, 2018, at 1:59 PM, Davide Italiano via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> davide added a comment.
> 
> In https://reviews.llvm.org/D41902#972619, @zturner wrote:
> 
>> In https://reviews.llvm.org/D41902#972614, @clayborg wrote:
>> 
>>> As long as:
>>> 
>>>  % lldb /path/to/Foo.app
>>>  (lldb) r
>>> 
>>> 
>>> Still works, then I am fine with this. The resolve executable should find the executable down inside the app bundle (like "/path/to/Foo.app/Contents/MacOS/Foo" for desktop apps and "/path/to/Foo.app/Foo" for iOS apps).
>> 
>> 
>> This sounds like something that would be pretty easy to write a test for with `lldb-test`.
> 
> 
> Yes, please add a test.
> 
> 
> https://reviews.llvm.org/D41902
> 
> 
>