[Lldb-commits] [lldb] r322188 - Add empty() function to the Environment class

[Davide Italiano via lldb-commits]

Also, the upstream `lldb-xcode` bot is red
http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/

On Wed, Jan 10, 2018 at 10:26 AM, Davide Italiano <dccitaliano at gmail.com> wrote:
> Picking a random commit in the `Environment` series.
> Hey Pavel, I'm currently seeing errors when building with Xcode
>
> Ld build/DebugClang/lldb-server normal x86_64
>
>     cd /Users/davide/work/lldb
>
>     export MACOSX_DEPLOYMENT_TARGET=10.11
>
>     /Volumes/Xcode10A36a_m18A103_i16A160a_t16J145_w16R149_XcodeInternals_29GB/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++
> -arch x86_64 -isysroot
> /Volumes/Xcode10A36a_m18A103_i16A160a_t16J145_w16R149_XcodeInternals_29GB/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk
> -L/Users/davide/work/lldb/build/DebugClang
> -L/Users/davide/work/lldb/llvm-build/Debug+Asserts/x86_64
> -F/Users/davide/work/lldb/build/DebugClang
> -F/Volumes/Xcode10A36a_m18A103_i16A160a_t16J145_w16R149_XcodeInternals_29GB/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/PrivateFrameworks
> -filelist /Users/davide/work/lldb/build/lldb.build/DebugClang/lldb-server.build/Objects-normal/x86_64/lldb-server.LinkFileList
> -exported_symbols_list tools/lldb-server/lldb-server.exports
> -mmacosx-version-min=10.11 -dead_strip -Xlinker -object_path_lto
> -Xlinker /Users/davide/work/lldb/build/lldb.build/DebugClang/lldb-server.build/Objects-normal/x86_64/lldb-server_lto.o
> -Xlinker -no_deduplicate -stdlib=libc++ -weak-lcompression -lz
> -filelist /Users/davide/work/lldb/llvm-build/Debug+Asserts/archives.txt
> -L/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config
> -lpython2.7 -lxml2 -framework DebugSymbols -framework Foundation
> -framework Carbon -framework Security -lpanel -lz -lncurses -ledit
> /Users/davide/work/lldb/build/DebugClang/liblldb-core.a -Xlinker
> -dependency_info -Xlinker
> /Users/davide/work/lldb/build/lldb.build/DebugClang/lldb-server.build/Objects-normal/x86_64/lldb-server_dependency_info.dat
> -o /Users/davide/work/lldb/build/DebugClang/lldb-server
>
>
> Undefined symbols for architecture x86_64:
>
>   "lldb_private::Environment::Envp::Envp(lldb_private::Environment
> const&)", referenced from:
>
>       lldb_private::Environment::getEnvp() const in
> liblldb-core.a(Host-9B62CE0F4D4B7B7B.o)
>
>   "lldb_private::Environment::Environment(char const* const*)", referenced from:
>
>       lldb_private::Environment::Environment(char* const*) in
> liblldb-core.a(Host-9B62CE0F4D4B7B7B.o)
>
>       lldb_private::Args::operator lldb_private::Environment() const
> in liblldb-core.a(Target.o)
>
> ld: symbol(s) not found for architecture x86_64
>
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
>
>
> Do you know what could be? (note this is a fresh build of lldb).
>
> Thanks!
>
> --
> Davide
>
>
> On Wed, Jan 10, 2018 at 6:17 AM, Pavel Labath via lldb-commits
> <lldb-commits at lists.llvm.org> wrote:
>> Author: labath
>> Date: Wed Jan 10 06:17:40 2018
>> New Revision: 322188
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=322188&view=rev
>> Log:
>> Add empty() function to the Environment class
>>
>> Needed to make the previous Freebsd fix work.
>>
>> Modified:
>>     lldb/trunk/include/lldb/Utility/Environment.h
>>
>> Modified: lldb/trunk/include/lldb/Utility/Environment.h
>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/Environment.h?rev=322188&r1=322187&r2=322188&view=diff
>> ==============================================================================
>> --- lldb/trunk/include/lldb/Utility/Environment.h (original)
>> +++ lldb/trunk/include/lldb/Utility/Environment.h Wed Jan 10 06:17:40 2018
>> @@ -46,6 +46,7 @@ public:
>>    using Base::begin;
>>    using Base::clear;
>>    using Base::count;
>> +  using Base::empty;
>>    using Base::end;
>>    using Base::erase;
>>    using Base::find;
>>
>>
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits