[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 9 06:51:55 PST 2018

mgorny added a comment.

In https://reviews.llvm.org/D41725#970926, @labath wrote:

> In https://reviews.llvm.org/D41725#969388, @mgorny wrote:
> > I was talking of:
> >
> >   source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
> >   source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
> Ah, right. These uses were introduced before we developed a preference for llvm primitives. That said, I see a lot of compression stuff there, but I don't see mention of zlib directly.

In the first of those files there are two `HAVE_LIBZ` conditionals that use zlib. There's also `HAVE_LIBCOMPRESSION` for the other library, I suppose it's relevant to Darwin.

Therefore, I have three questions:

1. Should we add a separate check/switch for zlib here, or just use `LLVM_ENABLE_ZLIB`?
2. Should I post a patch rewriting this little zlib bit to reuse libLLVMSupport?
3. Should I look into merging libcompression support into libLLVMSupport?

>>   tools/debugserver/source/RNBRemote.cpp
> Debugserver does not use llvm on purpose, but that should only worry you if your targetting darwin.
> In any case, lgtm.

Thanks, merged.



More information about the lldb-commits mailing list