[Lldb-commits] [PATCH] D41584: Check existence of each required component during construction of LLVMCDisassembler.
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jan 9 06:24:42 PST 2018
labath added a comment.
In https://reviews.llvm.org/D41584#970945, @tatyana-krasnukha wrote:
> Thank you, Pavel.
> Would you mind if I move LLVMCDisassembler declaration in .cpp also? It looks like perfect candidate for pimpl.
Yes, that sounds like a good idea.
> And... doesn't DisassemblerLLVMC::LLVMCDisassembler confuse anyone but me?)
Well... I haven't looked at this class in the past, but yes... it looks confusing. I wouldn't mind a name change.
Jason, any thoughts on this?
More information about the lldb-commits