[Lldb-commits] [PATCH] D41745: Handle O reply packets during qRcmd
Owen Shaw via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jan 8 15:15:19 PST 2018
owenpshaw updated this revision to Diff 128991.
owenpshaw added a comment.
Updated patch with new function name suggested by @clayborg. Added unit test and changed to llvm::function_ref as suggested by @labath.
Based on Greg's comments in the other thread, I've kept the new function separate, rather than use a flag in SendPacketAndWaitForResponse.
Is it worth creating a function to share the locking code that's common to SendPacketAndWaitForResponse and SendPacketAndReceiveResponseWithOutputSupport? Alternatively, should the lock-related error logging be unique to distinguish between the two functions?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 6518 bytes
Desc: not available
More information about the lldb-commits