[Lldb-commits] [PATCH] D41745: Handle O reply packets during qRcmd

[Owen Shaw via Phabricator via lldb-commits]

owenpshaw updated this revision to Diff 128991.
owenpshaw added a comment.

Updated patch with new function name suggested by @clayborg.  Added unit test and changed to llvm::function_ref as suggested by @labath.

Based on Greg's comments in the other thread, I've kept the new function separate, rather than use a flag in SendPacketAndWaitForResponse.

Is it worth creating a function to share the locking code that's common to SendPacketAndWaitForResponse and SendPacketAndReceiveResponseWithOutputSupport?  Alternatively, should the lock-related error logging be unique to distinguish between the two functions?


https://reviews.llvm.org/D41745

Files:
  source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteClientBase.h
  source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41745.128991.patch
Type: text/x-patch
Size: 6518 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180108/91a9e082/attachment.bin>