[Lldb-commits] [PATCH] D41352: debugserver: Propagate environment in launch-mode (pr35671)

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

The existing code for the "--forward-env" does this:

  case 'F':
    // Pass the current environment down to the process that gets launched
    {
      char **host_env = *_NSGetEnviron();
      char *env_entry;
      size_t i;
      for (i = 0; (env_entry = host_env[i]) != NULL; ++i)
        remote->Context().PushEnvironment(env_entry);
    }
    break;

Seems like your fix doesn't do the remote->Context().PushEnvironment(...). Not sure if this is needed or not.


https://reviews.llvm.org/D41352