[Lldb-commits] [PATCH] D41352: debugserver: Propagate environment in launch-mode (pr35671)

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

I guess I don't have an opinion on this one.  The correct way to pass environment variables to the inferior is through SBLaunchInfo::SetEnvironmentEntries or in cmd line lldb, process launch -v ENV=val.  A test that assumes an environment variable set in lldb will end up in the inferior process isn't going to work when the process is launched on a remote target, is it?

Whether llgs or debugserver should be forwarding their environment variables on by default - it seems fragile to me.  But maybe there's a use case that needs this behavior to be supported?  I guess it's valid to test that it actually behaves that way, at least for processes launched on the local system.

(I apologize for not keeping up with lldb-commits the past week while this was work was being done -- I'm in the middle of a task where I've had to concentrate on that & pause reading emails etc for a bit. ;)


https://reviews.llvm.org/D41352