[Lldb-commits] [lldb] r320883 - [MacOSX/Queues] Relax an overly aggressive assertion in a test.

Davide Italiano via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 15 14:22:51 PST 2017


Author: davide
Date: Fri Dec 15 14:22:51 2017
New Revision: 320883

URL: http://llvm.org/viewvc/llvm-project?rev=320883&view=rev
Log:
[MacOSX/Queues] Relax an overly aggressive assertion in a test.

"Default" is a valid QoS for a thread on older versions of macOS,
like the one installed in the bot.
Thanks to Jason Molenda for helping me figuring out the problem.

<rdar://problem/28346273>

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py?rev=320883&r1=320882&r2=320883&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py Fri Dec 15 14:22:51 2017
@@ -230,8 +230,9 @@ class TestQueues(TestBase):
                 "requested_qos.printable_name",
                 stream),
             "Get QoS printable string for unspecified QoS thread")
+        qosName = stream.GetData()
         self.assertTrue(
-            stream.GetData() == "User Initiated",
+            qosName == "User Initiated" or qosName == "Default",
             "unspecified QoS thread name is valid")
         stream.Clear()
         self.assertTrue(




More information about the lldb-commits mailing list