[Lldb-commits] [PATCH] D41245: Reduce x86 register context boilerplate.

Kamil Rytarowski via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 15 07:10:43 PST 2017

krytarowski added a comment.

In https://reviews.llvm.org/D41245#956644, @labath wrote:

> In https://reviews.llvm.org/D41245#955557, @krytarowski wrote:
> > Maybe reuse FPR for FXSAVE/FSAVE and add next to it XSAVE/XSAVE_OPT.
> I am not sure what you mean by that, but I don't think it can work that way, as xsave area already contains a copy of the fpu registers, so we will end up having them twice. I have a feeling that for supporting fsave you will need to define your own register context (or just handle the transformation at a different layer -- this is how we avoided defining separate register context for minidumps -- we just rearrange the registers around to match the existing register context layout).

I was thinking about split of FPU into two or more structs/unions.

But the newer version on review is better!


More information about the lldb-commits mailing list