[Lldb-commits] [PATCH] D41092: Enable more abilities in SymbolFilePDB

Aaron Smith via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Dec 13 10:42:39 PST 2017

asmith added inline comments.

Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:127
+  }
+  lldbassert(m_session_up.get());
+  if (auto enum_tables_up = m_session_up->getEnumTables()) {
clayborg wrote:
> I am assuming this assert won't fire if we give this an ELF or MachO file or any file that doesn't contain PDB info? Every SymbolFile subclass gets to calculate its abilities on each file until on of them returns that they can handle all abilities, or until all plug-ins have had a chance to answer and then the best one is picked. Seems like this shouldn't be here? I can't remember what checks get run before SymbolFile::CalculateAbilities() is called...
Any ELF or MachO other than PDB or PECOFF will error when calling loadDataForEXE or loadDataForPDB and return before reaching the assertion.



More information about the lldb-commits mailing list