[Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 11 13:40:58 PST 2017

SymbolFile does not have a method for searching by regex.  There is a
FindFunctions and FindGlobalVariables that allows searching by regex, but
not one for types.  That said, one could be added to the base class, yes.
That does seem like a better long term solution.

On Mon, Dec 11, 2017 at 1:37 PM Greg Clayton via Phabricator <
reviews at reviews.llvm.org> wrote:

> clayborg added a comment.
> We should have a dedicated API that actually searches for types using a
> lldb_private::RegularExpression. Why do we even try to create a regular
> expression in SymbolFilePDB::FindTypes()? Was it used in testing? No API in
> LLDB currently expects this and all other API in LLDB has a separate
> function call that uses lldb_private::RegularExpression. We can add one if
> needed to the lldb_private::SymbolFile API. I don't like API that magically
> tries to look at something and tries to compile a regular expression on
> each invocation. Can we change this?
> Repository:
>   rL LLVM
> https://reviews.llvm.org/D41086
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171211/513a0e47/attachment.html>

More information about the lldb-commits mailing list