[Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 11 10:25:06 PST 2017

What about adding GetMemorySize?
On Mon, Dec 11, 2017 at 10:23 AM Greg Clayton via Phabricator <
reviews at reviews.llvm.org> wrote:

> clayborg added a comment.
> I think GetFileSize() should remain the number of bytes of the section on
> disk and we should add new API if we need to figure out the decompressed
> size. Or maybe when we get bytes from a compressed section we are expected
> to always just get the raw bytes, then we check of the section is
> compressed, and if so, then we call another API on ObjectFile to decompress
> the data. So I would prefer GetFileSize() to return the file size of the
> section size in the file and not the decompressed size. Is there a way to
> make this work?
> https://reviews.llvm.org/D40616
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171211/b1b6b2f0/attachment.html>

More information about the lldb-commits mailing list