[Lldb-commits] [lldb] r319653 - Makefile.rules: compile all tests with -fno-limit-debug-info

Jason Molenda via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 5 17:54:40 PST 2017


It looks like the macos testsuite on the bot is broken with this -

http://lab.llvm.org:8080/green/view/LLDB/job/lldb/3086/

On my desktop with a recent clang, it works fine.  But it seems like every test? most tests? are failing with 

error: parsing line table prologue at 0x00000000 (parsing ended around 0x00000000

messages now.  

When I run one test by hand on my system, I have the -fno-limit-debug-info flag:

./dotest.py -t -v -v  ../packages//Python/lldbsuite/test/functionalities/breakpoint/auto_continue/



stdout: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -g -O0 -fno-builtin -arch x86_64  -I/Volumes/newwork/svn/lldb/packages/Python/lldbsuite/test/make/../../../../../include -include /Volumes/newwork/svn/lldb/packages/Python/lldbsuite/test/make/test_common.h -I/Volumes/newwork/svn/lldb/packages/Python/lldbsuite/test/make/  -fno-limit-debug-info  -std=c99   -c -o main.o main.c



I'm not sure if the bots are building against too new or too new a compiler - if we're looking at a bug or it just does something weird when given -fno-limit-debug-info?


> On Dec 4, 2017, at 5:31 AM, Pavel Labath via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> Author: labath
> Date: Mon Dec  4 05:31:56 2017
> New Revision: 319653
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=319653&view=rev
> Log:
> Makefile.rules: compile all tests with -fno-limit-debug-info
> 
> Summary:
> This flag is on by default for darwin and freebsd, but off for linux.
> Without it, clang will sometimes not emit debug info for types like
> std::string. Whether it does this, and which tests will fail because of
> that depends on the linux distro and c++ library version.
> 
> A bunch of tests were already setting these flags manually, but here
> instead I take a whole sale approach and enable this flag for all tests.
> Any test which does not want to have this flag (right now we have one
> such test) can turn it off explicitly via
> CFLAGS_EXTRAS+=$(LIMIT_DEBUG_INFO_FLAGS)
> 
> This fixes a bunch of data formatter tests on red-hat.
> 
> Reviewers: davide, jankratochvil
> 
> Subscribers: emaste, aprantl, krytarowski, JDevlieghere, lldb-commits
> 
> Differential Revision: https://reviews.llvm.org/D40717
> 
> Modified:
>    lldb/trunk/packages/Python/lldbsuite/test/expression_command/anonymous-struct/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/expression_command/call-function/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/expression_command/fixits/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-skip-summary/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/iterator/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/list/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/tuple/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/vector/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-synth/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/dump_dynamic/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/stringprinter/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/summary-string-onfail/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/var-in-aggregate-misuse/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/functionalities/type_completion/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/auto/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/stl/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/template/Makefile
>    lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
>    lldb/trunk/packages/Python/lldbsuite/test/python_api/sbvalue_persist/Makefile
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/anonymous-struct/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/expression_command/anonymous-struct/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/expression_command/anonymous-struct/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/expression_command/anonymous-struct/Makefile Mon Dec  4 05:31:56 2017
> @@ -2,11 +2,4 @@ LEVEL = ../../make
> 
> CXX_SOURCES := main.cpp
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/call-function/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/expression_command/call-function/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/expression_command/call-function/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/expression_command/call-function/Makefile Mon Dec  4 05:31:56 2017
> @@ -2,13 +2,6 @@ LEVEL = ../../make
> 
> CXX_SOURCES := main.cpp
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> clean::
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/fixits/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/expression_command/fixits/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/expression_command/fixits/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/expression_command/fixits/Makefile Mon Dec  4 05:31:56 2017
> @@ -2,11 +2,4 @@ LEVEL = ../../make
> 
> CXX_SOURCES := main.cpp
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-skip-summary/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-skip-summary/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-skip-summary/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-skip-summary/Makefile Mon Dec  4 05:31:56 2017
> @@ -3,13 +3,6 @@ LEVEL = ../../../make
> CXX_SOURCES := main.cpp
> USE_LIBSTDCPP := 0
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD 
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> CXXFLAGS += -O0
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/iterator/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/iterator/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/iterator/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/iterator/Makefile Mon Dec  4 05:31:56 2017
> @@ -5,11 +5,4 @@ CXX_SOURCES := main.cpp
> CFLAGS_EXTRAS += -O0
> USE_LIBSTDCPP := 1
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD 
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/list/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/list/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/list/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/list/Makefile Mon Dec  4 05:31:56 2017
> @@ -5,11 +5,4 @@ CXX_SOURCES := main.cpp
> CFLAGS_EXTRAS += -O0
> USE_LIBSTDCPP := 1
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD 
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile Mon Dec  4 05:31:56 2017
> @@ -4,11 +4,4 @@ CXX_SOURCES := main.cpp
> 
> USE_LIBSTDCPP := 1
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/Makefile Mon Dec  4 05:31:56 2017
> @@ -5,11 +5,4 @@ CXX_SOURCES := main.cpp
> CXXFLAGS := -O0
> USE_LIBSTDCPP := 1
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/Makefile Mon Dec  4 05:31:56 2017
> @@ -5,11 +5,4 @@ CXX_SOURCES := main.cpp
> CFLAGS_EXTRAS += -O0
> USE_LIBSTDCPP := 1
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD 
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/tuple/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/tuple/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/tuple/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/tuple/Makefile Mon Dec  4 05:31:56 2017
> @@ -3,6 +3,5 @@ LEVEL = ../../../../../make
> CXX_SOURCES := main.cpp
> 
> USE_LIBSTDCPP := 1
> -CFLAGS_EXTRAS += $(NO_LIMIT_DEBUG_INFO_FLAGS)
> 
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/Makefile Mon Dec  4 05:31:56 2017
> @@ -3,6 +3,5 @@ LEVEL = ../../../../../make
> CXX_SOURCES := main.cpp
> 
> USE_LIBSTDCPP := 1
> -CFLAGS_EXTRAS += $(NO_LIMIT_DEBUG_INFO_FLAGS)
> 
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/vector/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/vector/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/vector/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/vector/Makefile Mon Dec  4 05:31:56 2017
> @@ -5,11 +5,4 @@ CXX_SOURCES := main.cpp
> CXXFLAGS := -O0
> USE_LIBSTDCPP := 1
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-synth/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-synth/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-synth/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-synth/Makefile Mon Dec  4 05:31:56 2017
> @@ -2,11 +2,4 @@ LEVEL = ../../../make
> 
> CXX_SOURCES := main.cpp
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD 
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/dump_dynamic/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/dump_dynamic/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/dump_dynamic/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/dump_dynamic/Makefile Mon Dec  4 05:31:56 2017
> @@ -2,11 +2,4 @@ LEVEL = ../../../make
> CXX_SOURCES := main.cpp
> CXXFLAGS += -std=c++11
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD 
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/stringprinter/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/stringprinter/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/stringprinter/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/stringprinter/Makefile Mon Dec  4 05:31:56 2017
> @@ -2,11 +2,4 @@ LEVEL = ../../../make
> CXX_SOURCES := main.cpp
> CXXFLAGS += -std=c++11
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD 
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/summary-string-onfail/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/summary-string-onfail/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/summary-string-onfail/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/summary-string-onfail/Makefile Mon Dec  4 05:31:56 2017
> @@ -2,11 +2,4 @@ LEVEL = ../../../make
> 
> CXX_SOURCES := main.cpp
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD 
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/var-in-aggregate-misuse/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/var-in-aggregate-misuse/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/var-in-aggregate-misuse/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/var-in-aggregate-misuse/Makefile Mon Dec  4 05:31:56 2017
> @@ -2,10 +2,4 @@ LEVEL = ../../../make
> 
> CXX_SOURCES := main.cpp
> 
> -# Workaround for llvm.org/pr16214: clang doesn't emit structure definition DWARF
> -# information without the flag below.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/type_completion/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/type_completion/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/type_completion/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/type_completion/Makefile Mon Dec  4 05:31:56 2017
> @@ -2,11 +2,4 @@ LEVEL = ../../make
> 
> CXX_SOURCES := main.cpp
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD 
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/auto/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/auto/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/auto/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/auto/Makefile Mon Dec  4 05:31:56 2017
> @@ -2,6 +2,4 @@ LEVEL = ../../../make
> 
> CXX_SOURCES := main.cpp
> 
> -CFLAGS_EXTRAS += $(NO_LIMIT_DEBUG_INFO_FLAGS)
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/stl/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/stl/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/stl/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/stl/Makefile Mon Dec  4 05:31:56 2017
> @@ -5,11 +5,4 @@ CFLAGS := -g -O0
> 
> clean: OBJECTS+=$(wildcard main.d.*)
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD 
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/template/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/template/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/template/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/template/Makefile Mon Dec  4 05:31:56 2017
> @@ -2,6 +2,4 @@ LEVEL = ../../../make
> 
> CXX_SOURCES := main.cpp
> 
> -CFLAGS_EXTRAS += $(NO_LIMIT_DEBUG_INFO_FLAGS)
> -
> include $(LEVEL)/Makefile.rules
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Mon Dec  4 05:31:56 2017
> @@ -223,7 +223,8 @@ else
> 	CFLAGS += $(ARCHFLAG)$(ARCH) $(FRAMEWORK_INCLUDES) -I$(LLDB_BASE_DIR)include
> endif
> 
> -CFLAGS += -include $(THIS_FILE_DIR)test_common.h -I$(THIS_FILE_DIR) $(ARCH_CFLAGS) $(CFLAGS_EXTRAS)
> +CFLAGS += -include $(THIS_FILE_DIR)test_common.h -I$(THIS_FILE_DIR)
> +CFLAGS += $(NO_LIMIT_DEBUG_INFO_FLAGS) $(ARCH_CFLAGS) $(CFLAGS_EXTRAS)
> 
> # Use this one if you want to build one part of the result without debug information:
> ifeq "$(OS)" "Darwin"
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/sbvalue_persist/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/python_api/sbvalue_persist/Makefile?rev=319653&r1=319652&r2=319653&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/python_api/sbvalue_persist/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/python_api/sbvalue_persist/Makefile Mon Dec  4 05:31:56 2017
> @@ -5,11 +5,4 @@ CXX_SOURCES := main.cpp
> # Clean renamed executable on 'make clean'
> clean: OBJECTS+=no_synth
> 
> -# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD 
> -# targets.  Other targets do not, which causes this test to fail.
> -# This flag enables FullDebugInfo for all targets.
> -ifneq (,$(findstring clang,$(CC)))
> -  CFLAGS_EXTRAS += -fno-limit-debug-info
> -endif
> -
> include $(LEVEL)/Makefile.rules
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits



More information about the lldb-commits mailing list