[Lldb-commits] [PATCH] D40757: Disable warnings related to anonymous types

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.

In https://reviews.llvm.org/D40757#944293, @vsk wrote:

> I'd like to make this a narrower change as well, but unfortunately, I haven't found a way to add in extra CXX flags through the add_library or llvm_add_library utilities. Somebody tried to do this once in AddLLDB.cmake (see "set(CMAKE_CXX_FLAGS ...)"), but it's busted, and does not do anything, AFAICT.


Yeah, I believe the correct cmake incantation in this case should be:

  target_compile_options(lldbPluginObjCLanguage PRIVATE -Wno-nested-anon-types -Wno-gnu-anonymous-struct)

(placed just after add_lldb_library)

> In this case, I think it should be safe to disable these warnings project-wide, because they're not often (ever?) immediate indicators of correctness issues / undefined behavior. Given all of that, @labath are you OK with the patch as-is?

I'm fine with this as well, but since we both agree that a narrower scope would be better, maybe you could try the above snippet instead.


https://reviews.llvm.org/D40757