[Lldb-commits] [PATCH] D40745: Add a clang-ast subcommand to lldb-test

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

I'm sure this is just an "quick and dirty implementation" thing, but depending on the output of Dump functions doesn't seem like a great idea for long term stable testing.

Those functions are meant to be useful for debugging lldb, and gathering data when you can't get repro cases.  They probably don't want to have all the detail you might need, and are laid out for readability, so they are no more than ad hoc structured.

For instance, your dumpClangASTContext finds it's way to CompileUnit::Dump which doesn't actually call m_types->Dump.  That's probably because it was so noisy as to render the CU dump useless, though it was commented out before the sources were imported to llvm.org so I don't know for sure.

Because of that, this command is not currently useful for the purpose for which it was intended.  I think at present it doesn't actually dump anything that actually gets put into the AST, it just dumps Symbol file information which is not relevant, CU structures, Function blocks.


https://reviews.llvm.org/D40745