[Lldb-commits] [PATCH] D40717: Makefile.rules: compile all tests with -fno-limit-debug-info

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
Herald added subscribers: JDevlieghere, krytarowski, aprantl, emaste.

This flag is on by default for darwin and freebsd, but off for linux.
Without it, clang will sometimes not emit debug info for types like
std::string. Whether it does this, and which tests will fail because of
that depends on the linux distro and c++ library version.

A bunch of tests were already setting these flags manually, but here
instead I take a whole sale approach and enable this flag for all tests.
Any test which does not want to have this flag (right now we have one
such test) can turn it off explicitly via
CFLAGS_EXTRAS+=$(LIMIT_DEBUG_INFO_FLAGS)

Can you check whether this makes any difference for test results on
red-hat?


https://reviews.llvm.org/D40717

Files:
  packages/Python/lldbsuite/test/expression_command/anonymous-struct/Makefile
  packages/Python/lldbsuite/test/expression_command/call-function/Makefile
  packages/Python/lldbsuite/test/expression_command/fixits/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-skip-summary/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/iterator/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/list/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/tuple/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/vector/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-synth/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/dump_dynamic/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/stringprinter/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/summary-string-onfail/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/var-in-aggregate-misuse/Makefile
  packages/Python/lldbsuite/test/functionalities/type_completion/Makefile
  packages/Python/lldbsuite/test/lang/cpp/auto/Makefile
  packages/Python/lldbsuite/test/lang/cpp/stl/Makefile
  packages/Python/lldbsuite/test/lang/cpp/template/Makefile
  packages/Python/lldbsuite/test/make/Makefile.rules
  packages/Python/lldbsuite/test/python_api/sbvalue_persist/Makefile

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40717.125114.patch
Type: text/x-patch
Size: 15319 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171201/f203f6d2/attachment.bin>