[Lldb-commits] [lldb] r319472 - Fix this test so that the breakpoints you set are

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 30 12:43:00 PST 2017


Author: jingham
Date: Thu Nov 30 12:43:00 2017
New Revision: 319472

URL: http://llvm.org/viewvc/llvm-project?rev=319472&view=rev
Log:
Fix this test so that the breakpoints you set are
unambiguously on one bit of code.  On macOS these
lines mapped to two distinct locations, and that
was artificially throwing off the test.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/foo.cpp
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/main.cpp

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/foo.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/foo.cpp?rev=319472&r1=319471&r2=319472&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/foo.cpp (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/foo.cpp Thu Nov 30 12:43:00 2017
@@ -1,5 +1,7 @@
 #include "foo.h"
 
-Foo::Foo() : x(42) {} // !BR_foo
+Foo::Foo() : x(42) {
+    bool some_code = x == 42;  // !BR_foo
+} 
 
 Foo FooObj;

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/main.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/main.cpp?rev=319472&r1=319471&r2=319472&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/main.cpp (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/main.cpp Thu Nov 30 12:43:00 2017
@@ -5,7 +5,9 @@ struct Main {
   int x;
 };
 
-Main::Main() : x(47) {} // !BR_main
+Main::Main() : x(47) {
+    bool some_code = x == 47; // !BR_main
+}
 
 Main MainObj;
 




More information about the lldb-commits mailing list