[Lldb-commits] [PATCH] D40474: DWZ 11/12: Main functionality

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 30 06:17:32 PST 2017

jankratochvil marked 2 inline comments as done.
jankratochvil added inline comments.

Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:487
+  public:
+    // C++14: Use heterogenous lookup.
+    DWZCommonFile(const lldb_private::FileSpec &filespec_ref);
jankratochvil wrote:
> labath wrote:
> > Have you looked at llvm::DenseSet? It already supports heterogenous lookup( `find_as(...)`). It can also be more efficient than unordered_set.
> `llvm::DenseSet` should do the trick, thanks.
"//The iterators in a DenseMap are invalidated whenever an insertion occurs, unlike map.//" - there is now `std::unordered_set<DWZCommonFile, ...>` and a pointer to it by `DWZCommonFile *m_dwz_common_file;`.  So thanks for the hint but I do not find `DenseSet` to be applicable here.


More information about the lldb-commits mailing list