[Lldb-commits] [PATCH] D40615: Fix assertion in ClangASTContext

[Greg Clayton via Phabricator via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Few nits, but nothing that would hold up the patch. Looks good.



================
Comment at: include/lldb/Symbol/CompilerType.h:294
 
+  struct IntegralTemplateArgument;
+
----------------
Can't you just define the type right here?


================
Comment at: source/Plugins/Language/CPlusPlus/LibCxxBitset.cpp:62-63
   size_t size = 0;
-  auto value_and_type =
-      m_backend.GetCompilerType().GetIntegralTemplateArgument(0);
-  if (value_and_type.second)
-    size = value_and_type.first.getLimitedValue(capping_size);
+  auto arg = m_backend.GetCompilerType().GetIntegralTemplateArgument(0);
+  if (arg)
+    size = arg->value.getLimitedValue(capping_size);
----------------
Should we combine these two lines?

```
if (auto arg = m_backend.GetCompilerType().GetIntegralTemplateArgument(0))
```


https://reviews.llvm.org/D40615