[Lldb-commits] [PATCH] D40537: Simplify UUID::IsValid()

Davide Italiano via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 27 21:38:30 PST 2017

davide added a comment.

Yes, what Zachary said. Thanks for the cleanup. There's a decent amount of code in lldb that can be written in a very compact way but it's manually unrolled. I think in this case the code produced should be equivalent (and if not, I'd be curious to see the codegen).
More generally, whenever a function is not in a hot loop, we might consider preferring readability over performances anyway.


More information about the lldb-commits mailing list