[Lldb-commits] [PATCH] D40468: DWZ 05/12: Support reading section ".gnu_debugaltlink"

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 27 10:24:08 PST 2017

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Just move the eSectionTypeDWARFGNUDebugAltLink enumerator to the end of the enum and this is good to go.

Comment at: include/lldb/lldb-enumerations.h:647
+  eSectionTypeDWARFGNUDebugAltLink,
   eSectionTypeELFSymbolTable,       // Elf SHT_SYMTAB section
Since this enumeration is in the public API, it should be added to the end of the enum. Anyone that builds a new liblldb.so and then uses it with an binary compiled before could run into issues. But I noticed eSectionTypeDWARFDebugCuIndex was added in the middle in August, but we need to avoid these kinds of API issues, so lets add this to the end just to be safe.


More information about the lldb-commits mailing list