[Lldb-commits] [PATCH] D40311: elf-core: Split up parsing code into os-specific functions

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 22 03:58:08 PST 2017

labath added inline comments.

Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:735
 ///   (see ELFNote structure)
 /// 3) A Thread Context in a core file usually described by 3 NOTE entries.
 ///    a) NT_PRSTATUS - Register context
krytarowski wrote:
> Can we label it as SVR4-style (Linux, FreeBSD, Solaris)? Alternatively move it to other place in order to describe Linux and FreeBSD separately (NetBSD an OpenBSD can be skipped now).
Yeah, I was wondering what to do with that comment -- it is so vague it is nearly useless. I agree we should move the core file description to the individual OS's parsing functions. I've written a description of the linux notes. Freebsd ones seem pretty similar, but don't know enough about them to say if the description applies to them as well.


More information about the lldb-commits mailing list