[Lldb-commits] [PATCH] D40212: refactor: Unify+simplify DWARFCompileUnit ctor+Clear() into in-class initializers

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Nov 19 10:34:20 PST 2017


jankratochvil added a comment.

In https://reviews.llvm.org/D40212#929716, @clayborg wrote:

> Good change in the header file.


If you mean the in-class initializers they obviously cannot be used without the in-place construction+destruction as they would stay duplicate to the Clear() method.

OK if you are also uncomfortable with it I will keep Clear() as is and just call Clear() from the ctor to unify it at least a bit.


https://reviews.llvm.org/D40212





More information about the lldb-commits mailing list