[Lldb-commits] [PATCH] D39969: Set error status in ObjectFile::LoadInMemory if it is not set

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha added inline comments.


================
Comment at: source/Symbol/ObjectFile.cpp:695
+              "One or more breakpoints intersect section '%s'",
+              section_sp->GetName().AsCString());
         return error;
----------------
abidh wrote:
> If WriteMemory is not setting the error in some case, it seem more logical to properly handle it there instead of putting this specific error message here.
Process::WriteMemory doesn't treat this case as error. This depends on context of usage. I wanted to do as you propose, but was afraid for breaking all other use cases...


Repository:
  rL LLVM

https://reviews.llvm.org/D39969