[Lldb-commits] [PATCH] D39966: Add a data formatter for libc++ std::bitset

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 13 12:22:25 PST 2017

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

Looks fine.  Seems like Update doesn't need to grab the bool type on every pass, but I don't think that matters IRL.  Thanks for adding this.

Comment at: source/Plugins/Language/CPlusPlus/LibCxxBitset.cpp:62
+  m_bool_type = m_backend.GetCompilerType().GetBasicTypeFromAST(eBasicTypeBool);
+  m_elements.assign(size, ValueObjectSP());
Does this need to be done every time you Update?  Couldn't you do this in the constructor instead?  This is probably pretty cheap call, so it doesn't matter much, but it seems odd.


More information about the lldb-commits mailing list