[Lldb-commits] [PATCH] D39896: Remove last Host usage from ArchSpec

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 10 04:02:00 PST 2017


labath created this revision.

In https://reviews.llvm.org/D39387, I was quick to jump to conclusion that ArchSpec has no
external dependencies. It turns there still was one call to
HostInfo::GetArchitecture left -- for implementing the "systemArch32"
architecture and friends.

Since GetAugmentedArchSpec is the place we handle these "incomplete"
triples that don't specify os or vendor and "systemArch" looks very much
like an incomplete triple, I move its handling there.

After this ArchSpec *really* does not have external dependencies, and
I'd like to move it to the Utility module as a follow-up.


https://reviews.llvm.org/D39896

Files:
  include/lldb/Host/HostInfoBase.h
  source/Core/ArchSpec.cpp
  source/Host/common/HostInfoBase.cpp
  source/Target/Platform.cpp
  unittests/Host/HostInfoTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39896.122416.patch
Type: text/x-patch
Size: 4237 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171110/adad4c26/attachment.bin>


More information about the lldb-commits mailing list