[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 10 02:55:42 PST 2017


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good, thank you. Just please make sure you change the file name at top of the new header file and add inclusion guards.



================
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:1
+//===-- ProcessElfCore.cpp --------------------------------------*- C++ -*-===//
+//
----------------
labath wrote:
> Please update the file name here and add header guards.
I think you've missed this one.


https://reviews.llvm.org/D39681





More information about the lldb-commits mailing list