[Lldb-commits] [PATCH] D39844: CompilerType: Add ability to retrieve an integral template argument

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: include/lldb/Symbol/TypeSystem.h:356-360
+  virtual CompilerType GetTypeTemplateArgument(lldb::opaque_compiler_type_t type,
+                                           size_t idx) = 0;
+  virtual std::pair<llvm::APSInt, CompilerType>
+  GetIntegralTemplateArgument(lldb::opaque_compiler_type_t type,
+                              size_t idx) = 0;
----------------
Why not make three functions:
- get kind by index
- get type by index
- get integer by index

The "get integer by index" would only work if the kind was eTemplateArgumentKindIntegral? Not sure why we have the pair getter?


https://reviews.llvm.org/D39844