[Lldb-commits] [PATCH] D35356: [zorg] Enable assertions on the linux lldb bot

[Pavel Labath via Phabricator via lldb-commits]

labath marked an inline comment as done.
labath added a comment.

I am sorry about the delay, I was on extended leave.



================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:921
                        scriptExt='.sh',
+                       extra_cmake_args=[],
                        ):
----------------
gkistanova wrote:
> Please do not use mutable default arguments.
> See http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments for more details.
> 
Wow, that's quite a surprise. I was not aware of that.


================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:954
     getShellCommandStep(f, name='cmake local',
-                        command=[pathSep + 'cmake' + scriptExt])
+                        command=[pathSep + 'cmake' + scriptExt] + extra_cmake_args)
 
----------------
gkistanova wrote:
> This is not a blocker for this patch. With all the same, it would be nice to use the CmakeCommand here instead of the ShellCommand.
These buildbots deliberately invoke scripts instead of running the commands directly to provide an opportunity to tweak the configuration without restarting the master. I'm honestly not sure whether that was the right choice to begin with, but backing out of that now is not something I feel comfortable doing as a part of this patch.


https://reviews.llvm.org/D35356