[Lldb-commits] [PATCH] D39689: Add a dependency from check-lldb on lld

[Zachary Turner via Phabricator via lldb-commits]

zturner accepted this revision.
zturner added inline comments.


================
Comment at: test/CMakeLists.txt:116-122
+  if (CMAKE_SYSTEM_NAME MATCHES "Windows")
+    if (TARGET lld)
+      add_dependencies(check-lldb lld)
+    else ()
+      message(WARNING "lld required to test LLDB on Windows")
+    endif ()
+  endif ()
----------------
I would probably move this outside of the `if (TARGET clang)`.  This is minor though, as I can think of ways to break this both with the current patch (inside of the check) as well as outside of the check.


https://reviews.llvm.org/D39689