[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

[Don Hinton via Phabricator via lldb-commits]

hintonda updated this revision to Diff 121350.
hintonda added a comment.

I realize this probably isn't an acceptable change, but it was a good
learing experience for me, as I'd never looked at the lldb code before
last Sunday, so I figured I'd go ahead and complete it.

While the basic technique remains the same, this version just adds a
single enum value, ePathSyntaxRegex, and modifies PathSyntaxIsPosix()
to treat it as a posix path so it doesn't get modified.

The logic for testing the regex was moved to
FileSpecList::FindFileIndex() which does the filtering and already
deals with equality issues, e.g., whether or not to include the
directory in the match.

Finally, the SB API was modified to use accept a new regex flag, and a
test was added.

Thanks again for all your feedback and suggestions...


https://reviews.llvm.org/D39436

Files:
  include/lldb/API/SBFileSpec.h
  include/lldb/Utility/FileSpec.h
  packages/Python/lldbsuite/test/python_api/breakpoint/TestBreakpointAPI.py
  scripts/interface/SBFileSpec.i
  source/API/SBFileSpec.cpp
  source/Commands/CommandObjectBreakpoint.cpp
  source/Core/FileSpecList.cpp
  source/Utility/FileSpec.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39436.121350.patch
Type: text/x-patch
Size: 7271 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171102/2b9f9490/attachment-0001.bin>