[Lldb-commits] [PATCH] D38829: Python: SetOutputFileHandle doesn't work with IOBase

[Zachary Turner via Phabricator via lldb-commits]

zturner added a comment.

Ok, I wasn't aware of the libedit problem.

I still don't like this approach, because it causes the design of the `File` class to be influenced by a limitation of a 3rd party library.

What about adding a method to `IOObject` called `FILE *GetFileStream()`.  Then the method I proposed earlier would just involve `PythonFileIo` implementing this in the proper way.  Then we can pass `SBFile` or `lldb_private::File` through all layers of the codebase, and once we're in libedit we just call `file.GetFileStream()` and pass it to libedit?


Repository:
  rL LLVM

https://reviews.llvm.org/D38829