[Lldb-commits] [PATCH] D39515: Remove TestMyFirstWatchpoint and TestStepOverWatchpoint from basic_process category

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

Setting categories on directories seems much less useful if you then have to scan through all the tests and see if any of the tests in the directories you've added categories to implement getCategories then add the new category to the return from getCategories list as well.

So it seems to me either getCategories should add to the directory category list that's already been computed, or we should remove it altogether.

There are only a few other tests that implement getCategories (all to set it to basic_process).  So it does look like this is more degrees of freedom than we actually need.  Maybe we should just remove it altogether?  I don't feel too strongly, but if we're going to remove it from these tests we should probably remove it everywhere or we'll make somebody else have to figure this out again down the line.


https://reviews.llvm.org/D39515