[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

[Zachary Turner via lldb-commits]

On Tue, Oct 31, 2017 at 8:12 AM Don Hinton <hintonda at gmail.com> wrote:

> There have been a few suggestions that I could just use a script to solve
> this "problem" -- poor startup performance of clangdiag.
>
> However, this patch was not submitted to solve a particular problem.  It
> was submitted in response to Jim's suggestion:
>
> On Mon, Oct 23, 2017 at 6:25 PM, Jim Ingham <jingham at apple.com> wrote:
>
>> Yeah, that would be easy to implement from the command line, maybe add a
>> --file-is-regex flag or something.
>>
>> From the SB API it would be better to have something like:
>>
>> SBFileList SBTarget.GetFileListMatchingRegex("regex")
>>
>> Please file an enhancement request for these of hack'em in if you're so
>> motivated.
>>
>
> clangdiag was only provided as a motivating example.
>

Fair point, I had forgotten about that.  That said, I'm honestly still not
that big of a fan.   It's no secret that I have a higher bar than others
for options and API additions, but to me the potential use this particular
option + SB API would get is not sufficient to justify the long term
maintenance burden associated with having it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171031/1c6cab5f/attachment.html>