[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

I do think "all inlines of line 7 of my_cool_templates.h in some_file.cpp" is potentially useful.  So adding a "source-pattern" and using it as a limiter for a search in much the same way --shlib is used seems generally useful to me.  So it seems worthwhile adding this as its own option.

Whether we remove --all-files at the same time is a separate issue.  I don't see much need to remove it.  The most common cases for -p are the current file & all-files so having an accelerator for it (and one that will avoid running a needless regex compare against every filename) seems reasonable.


https://reviews.llvm.org/D39436