[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

Zachary's suggestion is better than adding regex patterns to FileSpec, but I still don't like the idea of encoding option types in the option values.

Moreover, this doesn't really apply to the main use of -f - file & line breakpoints.  The only plausible use for a source file filter for file & line breakpoints is when you want to restrict breaking on inlined code to a subset of the files that inline it.  But in that case you would want a separate option, since you need to specify the inlined file = with the -f option - and the inlining files - with some other option.

Wouldn't it be better to add a --source-file-regex option, pick some free single letter, and use that if you want to provide a pattern for the "-p" breakpoint option.  Then we could also use it when specifying some other file filter.


https://reviews.llvm.org/D39436