[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

[Jim Ingham via Phabricator via lldb-commits]

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

I don't like this change.

First off, the whole point of having options in the commands is so that we don't have to have magic encodings in the values.

We also don't have FileSpec's that resolve to multiple files.  What do "Exists", "IsExecutable",  "GetPath" etc. mean in this context?  There would have to be a really strong reason for making this kind of change.  Just avoiding an extra option does not warrant this change so far as I can see.


https://reviews.llvm.org/D39436