[Lldb-commits] [PATCH] D39315: Correct the start address for exported windows functions in arm

[Stephane Sezer via Phabricator via lldb-commits]

sas added a comment.

In https://reviews.llvm.org/D39315#908251, @zturner wrote:

> In https://reviews.llvm.org/D39315#908246, @sas wrote:
>
> > Same thing here, I have no idea how to go about testing something specific like this. Given that this is Windows Phone, it's even worse than simply Windows Desktop because the only way to test is by doing remote debugging. I suppose checking in binaries to the tree so we can analyze the symbols and ensure correctness is the only way to do it?
>
>
> Do you guys not have access to Windows Desktops?  It sounds like we need to get remote debugging of Windows targets working.  I don't think I'm gonna be the one to do that in the near future, but if it's going to be a frequent thing that you're improving windows support for remote targets like Windows Phone, I imagine you're going to want the code to be tested, so hopefully you can convince someone to give you cycles to make remote debugging work properly, otherwise you're shipping untested code :-/


Well as far as I can tell, remote debugging for Windows **does** work, assuming you use ds2 on the remote, and that you have a few of our local patches (which I'm trying to send upstream currently). Remote Windows debugging is the **only** way we debug on Windows for now and the testing we have is just a combination of people using our tools internally as well as some end-to-end tests we run internally with full debug session setup + breakpoints + execution control, etc, with a remote session.

Given that this works for us, I'm gonna have a hard time justifying assigning people to bringing up windows remote debugging in lldb without ds2, and that leaves me in a state where testing stuff **in** lldb is hard/impossible for now.


https://reviews.llvm.org/D39315