[Lldb-commits] [PATCH] D31172: Move stop info override callback code from ArchSpec into Process

[Zachary Turner via Phabricator via lldb-commits]

zturner accepted this revision.
zturner added a comment.

I will ping them for some numbers and more details of their test setup.  Regardless, I didn't mean to derail the code review.  But, I really really want to reach a point where we can stop falling back on the "we need to be safe even in the presence of stuff that is clearly not user input" argument.  I understand the concerns, but I don't think this is a reasonable path forward for the project.  If it's not user input, if we own it, then we can make whatever assumption we want that leads to the best performance and memory usage characteristics.

As I said this is a pretty uninteresting case, and probably makes no difference since we're talking about 30-40 strings in the whole program, so I'll leave it at that.  But I will probably push on this harder in the future if it's in some other area of code that has a larger impact.


https://reviews.llvm.org/D31172