[Lldb-commits] [PATCH] D31172: Move stop info override callback code from ArchSpec into Process

[Greg Clayton via lldb-commits]

Looks fine. We can start with this. I was thinking it would be nice to lazily populate m_plugin_up, but then we would need to add a bit to see if we already tried to look for it, so the current approach will work fine.

> On Oct 24, 2017, at 1:22 PM, Pavel Labath via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> labath added a comment.
> 
> I'm back now, and I'd like to try to push this patch to completion.
> 
> After re-reading the discussion, I got the impression we have mostly reached a consensus here. A small issue remained about how to guarantee that the Architecture plugin and the ArchSpec object are in sync. Several versions were thrown around, with no clear conclusion.
> 
> Does anyone hav objections to how this part is implemented in the last version of the patch? If not, I'd like to put this in...
> 
> 
> https://reviews.llvm.org/D31172
> 
> 
>