[Lldb-commits] [PATCH] D39215: Default to using in-tree clang for building test executables

[Zachary Turner via Phabricator via lldb-commits]

zturner added a comment.

In https://reviews.llvm.org/D39215#904615, @zturner wrote:

> In https://reviews.llvm.org/D39215#904578, @labath wrote:
>
> > I've played around with this, but I couldn't get the `lit/lit.site.cfg.in` file to see the expanded values of the `$<TARGET_FILE:clang>` generator expression (the reason it works now is because the file is special-casing LLDB_TEST_CLANG=True). Currently, I do not see how to work around that.
> >
> > So, I propose to separate the functional change from the cleanup, and leave the cleanup part to someone with more cmake-fu. :P
>
>
> I think we just need to do:
>
>   set(DEFAULT_LLDB_TEST_COMPILER "$<TARGET_FILE:clang>")
>  
>   set(LLDB_TEST_COMPILER "${DEFAULT_LLDB_TEST_COMPILER}" CACHE PATH "Path to clang executable used to run LLDB tests")
>
>
> Does this not work?


Oh, and then inside the `lit.site.cfg.in`, use `%LLDB_TEST_COMPILER%` everywhere.


https://reviews.llvm.org/D39215