[Lldb-commits] [PATCH] D39199: [lldbtests] Handle errors instead of crashing

Davide Italiano via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 23 12:41:54 PDT 2017


davide added a comment.

If there are cases where `is_exe` shouldn't be fatal, then we might consider splitting the utility into two bits (exists & is_exe).
In my mind, if you're checking whether something is executable you should run the check on a valid entity, and it's up to the caller guaranteeing the validity (we should, of course, check here).


https://reviews.llvm.org/D39199





More information about the lldb-commits mailing list