[Lldb-commits] [PATCH] D39199: [lldbtests] Handle errors instead of crashing

Davide Italiano via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 23 12:13:47 PDT 2017


davide added inline comments.


================
Comment at: packages/Python/lldbsuite/test/dotest.py:56
+        sys.exit(-1)
     return os.path.isfile(fpath) and os.access(fpath, os.X_OK)
----------------
lemo wrote:
> minor: can we print quotes around fpath? (this usually helps in messages to avoid confusion around paths containing spaces for ex)
Sure, I'll change that before committing if people like the approach.


Repository:
  rL LLVM

https://reviews.llvm.org/D39199





More information about the lldb-commits mailing list