[Lldb-commits] [PATCH] D38938: Logging: provide a way to safely disable logging in a forked process

Eugene Zemtsov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 23 10:08:54 PDT 2017


eugene accepted this revision.
eugene added inline comments.
This revision is now accepted and ready to land.


================
Comment at: source/Utility/Log.cpp:333
+
+void Log::DisableLoggingChild() {
+  for (auto &c: *g_channel_map)
----------------
A little comment here describing nature of a deadlock if we don't disable logging would be nice.


https://reviews.llvm.org/D38938





More information about the lldb-commits mailing list