[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 13 13:04:15 PDT 2017

clayborg added a comment.

I agree with all of Zach's suggestions.

Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.h:98-99
+    uint32_t refcount;      // Serves as enable/disable and reference counter.
+    long slot;              // Saves the value returned from PTRACE_SETHWDEBUG.
+    int mode;               // Defines if watchpoint is read/write/access.
+  };
As long as this code is only ever compiled native, using "long" and "int" are ok. Just beware of code that isn't always compiled native.


More information about the lldb-commits mailing list