[Lldb-commits] [PATCH] D38552: LLDB cmake fix: define LLDB_CONFIGURATION_xxx based on the build type

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 4 11:04:19 PDT 2017

zturner added inline comments.

Comment at: CMakeLists.txt:15
+# Define the LLDB_CONFIGURATION_xxx matching the build type
+  add_definitions( -DLLDB_CONFIGURATION_DEBUG )
I'm pretty sure that if you run CMake without specifying anything for `CMAKE_BUILD_TYPE` then the default is debug, but it doesn't internally set `CMAKE_BUILD_TYPE=Debug`.  Can you double check this handles the default case appropriately?


More information about the lldb-commits mailing list