[Lldb-commits] [PATCH] D38323: Enable breakpoints and read/write GPRs for ppc64le

[Alexandre Yukio Yamashita via Phabricator via lldb-commits]

alexandreyy added a comment.

Are these changes ok?
I am implementing the read/write functions for the other registers.
And I will add it later.

In https://reviews.llvm.org/D38323#883429, @clayborg wrote:

> Looks fine. One main questions for new linux archs in particular: is linux using the lldb-server to debug these days even when debugging locally? If so, then this patch only needs to implement both a native register content and not the lldb_private::RegisterContext subclass.


When I debug locally, the lldb launches the lldb-server. 
However, the remote debug is not working yet. The server crashes when I try to launch a process.

It shows that error:
lldb-server: /lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp:134: lldb_private::Status lldb_private::process_gdb_remote::GDBRemoteCommunicationServerPlatform::LaunchGDBServer(const lldb_private::Args&, std::__cxx11::string, lldb::pid_t&, uint16_t&, std::__cxx11::string&): Assertion `ok' failed.

I will investigate that later.



================
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.h:66-68
+  struct Reg {
+    uint8_t bytes[8];
+  };
----------------
alexandreyy wrote:
> clayborg wrote:
> > Any reason to not use "uint64_t" instead of "struct Reg"?
> Changed to uint64_t.
Changed register set type to GPR.


https://reviews.llvm.org/D38323