[Lldb-commits] [PATCH] D38373: Add a few missing newlines in lldb-server messages

[Stephane Sezer via Phabricator via lldb-commits]

sas created this revision.

https://reviews.llvm.org/D38373

Files:
  tools/lldb-server/lldb-gdbserver.cpp


Index: tools/lldb-server/lldb-gdbserver.cpp
===================================================================
--- tools/lldb-server/lldb-gdbserver.cpp
+++ tools/lldb-server/lldb-gdbserver.cpp
@@ -251,12 +251,12 @@
     auto connection_result = connection_up->Connect(connection_url, &error);
     if (connection_result != eConnectionStatusSuccess) {
       fprintf(stderr, "error: failed to connect to client at '%s' "
-                      "(connection status: %d)",
+                      "(connection status: %d)\n",
               connection_url, static_cast<int>(connection_result));
       exit(-1);
     }
     if (error.Fail()) {
-      fprintf(stderr, "error: failed to connect to client at '%s': %s",
+      fprintf(stderr, "error: failed to connect to client at '%s': %s\n",
               connection_url, error.AsCString());
       exit(-1);
     }
@@ -287,7 +287,7 @@
       // Ensure we have a port number for the connection.
       if (connection_portno == 0) {
         fprintf(stderr, "error: port number must be specified on when using "
-                        "reverse connect");
+                        "reverse connect\n");
         exit(1);
       }
 
@@ -301,20 +301,20 @@
       auto connection_result = connection_up->Connect(connection_url, &error);
       if (connection_result != eConnectionStatusSuccess) {
         fprintf(stderr, "error: failed to connect to client at '%s' "
-                        "(connection status: %d)",
+                        "(connection status: %d)\n",
                 connection_url, static_cast<int>(connection_result));
         exit(-1);
       }
       if (error.Fail()) {
-        fprintf(stderr, "error: failed to connect to client at '%s': %s",
+        fprintf(stderr, "error: failed to connect to client at '%s': %s\n",
                 connection_url, error.AsCString());
         exit(-1);
       }
     } else {
       std::unique_ptr<Acceptor> acceptor_up(
           Acceptor::Create(final_host_and_port, false, error));
       if (error.Fail()) {
-        fprintf(stderr, "failed to create acceptor: %s", error.AsCString());
+        fprintf(stderr, "failed to create acceptor: %s\n", error.AsCString());
         exit(1);
       }
       error = acceptor_up->Listen(1);
@@ -328,15 +328,15 @@
         if (named_pipe_path && named_pipe_path[0]) {
           error = writeSocketIdToPipe(named_pipe_path, socket_id);
           if (error.Fail())
-            fprintf(stderr, "failed to write to the named pipe \'%s\': %s",
+            fprintf(stderr, "failed to write to the named pipe \'%s\': %s\n",
                     named_pipe_path, error.AsCString());
         }
         // If we have an unnamed pipe to write the socket id back to, do that
         // now.
         else if (unnamed_pipe_fd >= 0) {
           error = writeSocketIdToPipe(unnamed_pipe_fd, socket_id);
           if (error.Fail())
-            fprintf(stderr, "failed to write to the unnamed pipe: %s",
+            fprintf(stderr, "failed to write to the unnamed pipe: %s\n",
                     error.AsCString());
         }
       } else {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38373.117032.patch
Type: text/x-patch
Size: 3101 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170928/1d8eb269/attachment.bin>