[Lldb-commits] [PATCH] D38323: Enable breakpoints and read/write GPRs for ppc64le

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.h:71
+  RegInfo m_reg_info;
+  Reg m_gpr_ppc64le[48]; // 64-bit general purpose registers.
+
----------------
Could we share the structure that backs all registers from the RegisterInfos_ppc64le.h file here? Or are there multiple flavors of registers for different OSs and this is just big enough for both?


================
Comment at: source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.h:64-69
+  struct Reg {
+    uint8_t bytes[8];
+  };
+
+  // 64-bit general purpose registers.
+  Reg m_gpr_ppc64le[48]; // 64-bit general purpose registers.
----------------
clayborg wrote:
> uint64_t instead?
Could we share the structure that backs all registers from the RegisterInfos_ppc64le.h file here? Or are there multiple flavors of registers for different OSs and this is just big enough for both?


https://reviews.llvm.org/D38323